Open MichaelGrupp opened 3 years ago
Hey, just wanted to know whether ros2 branch builds with foxy ?. Please let me know if anyone has tried. Thank you
Hey, just wanted to know whether ros2 branch builds with foxy ?. Please let me know if anyone has tried. Thank you
It seems that the install fails. I created an issue #1579.
@jediofgever Work in progress. Not yet ready to build.
@seasony-vp This is unrelated to this issue. You are referring to the old port made by OSRF, we plan to make a new one here.
Dear @MichaelGrupp
Work in progress. Not yet ready to build.
Do you have any updates regarding this?
I didn't have the time for continuing the WIP state recently. But I will update here once there's something new.
PR for rolling/galactic here https://github.com/cartographer-project/cartographer_ros/pull/1622 (should maybe target a new branch ?)
Components
cartographer_ros/CMakeLists.txt
)cartographer_ros/cartographer_ros/CMakeLists.txt
)The library cmake file uses a glob filter to get all
.cc
files. This could be changed for the period of porting, to allow porting only a subset of files at a time (in correct dependency order of course).Regarding executables I would say the first goal should be to port
node_main.cc
, thenoffline_node_main.cc
and then all the remaining tools. Files that don't build yet should be excluded from the build temporarily, by commenting out in the cmake file.How to test locally with Docker
Can be done in addition to building with
colcon
in your personal workspace. This is how we would test before merging, so it makes also sense to test it like this locally.Once #1543 and #1542 are merged, you can activate the build of cartographer_ros in
Dockerfile.foxy
and inscripts/install_debs.sh
(see TODO comments in these files). Then runto build your branch (dashing can be done the same way).
As written also in #1536, you can have a look also at the outdated old port on the
ros2-dashing-1.0.0
branch.