cartographer-project / cartographer_ros

Provides ROS integration for Cartographer.
Apache License 2.0
1.65k stars 1.2k forks source link

ROS2 port of cartographer_ros (library & executables) #1557

Open MichaelGrupp opened 3 years ago

MichaelGrupp commented 3 years ago

Components

The library cmake file uses a glob filter to get all .cc files. This could be changed for the period of porting, to allow porting only a subset of files at a time (in correct dependency order of course).

Regarding executables I would say the first goal should be to port node_main.cc, then offline_node_main.cc and then all the remaining tools. Files that don't build yet should be excluded from the build temporarily, by commenting out in the cmake file.

How to test locally with Docker

Can be done in addition to building with colcon in your personal workspace. This is how we would test before merging, so it makes also sense to test it like this locally.

Once #1543 and #1542 are merged, you can activate the build of cartographer_ros in Dockerfile.foxy and in scripts/install_debs.sh (see TODO comments in these files). Then run

docker build . --file Dockerfile.foxy --tag cartographer_ros:foxy

to build your branch (dashing can be done the same way).


As written also in #1536, you can have a look also at the outdated old port on the ros2-dashing-1.0.0 branch.

jediofgever commented 3 years ago

Hey, just wanted to know whether ros2 branch builds with foxy ?. Please let me know if anyone has tried. Thank you

seasony-vp commented 3 years ago

Hey, just wanted to know whether ros2 branch builds with foxy ?. Please let me know if anyone has tried. Thank you

It seems that the install fails. I created an issue #1579.

MichaelGrupp commented 3 years ago

@jediofgever Work in progress. Not yet ready to build.

@seasony-vp This is unrelated to this issue. You are referring to the old port made by OSRF, we plan to make a new one here.

imstevenpmwyca commented 3 years ago

Dear @MichaelGrupp

Work in progress. Not yet ready to build.

Do you have any updates regarding this?

MichaelGrupp commented 3 years ago

I didn't have the time for continuing the WIP state recently. But I will update here once there's something new.

doisyg commented 3 years ago

PR for rolling/galactic here https://github.com/cartographer-project/cartographer_ros/pull/1622 (should maybe target a new branch ?)