cartographer-project / cartographer_turtlebot

Provides TurtleBot integration for Cartographer.
Apache License 2.0
151 stars 96 forks source link

Add the dependency ceres-solver in the .rosinstall file. #45

Closed renweizhukov closed 7 years ago

renweizhukov commented 7 years ago

This commit fixes #44.

Change-Id: Idfb989aa23df74a37ddbe800e01ea366a0215b91 Signed-off-by: Wei Ren renwei2004@gmail.com

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


renweizhukov commented 7 years ago

I signed it!

On Fri, Feb 17, 2017 at 11:41 AM, googlebot notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/googlecartographer/cartographer_turtlebot/pull/45#issuecomment-280746956, or mute the thread https://github.com/notifications/unsubscribe-auth/ALL2My9hhES0exia2ykCKf5SdymgMc5Eks5rdffdgaJpZM4MEqut .

SirVer commented 7 years ago

@renweizhukov Our CLA database does not contain your github user name. Did you use the same email address that you used for the github commit to sign the CLA?

renweizhukov commented 7 years ago

Sorry, my bad. I accidentally used a different email address in the github commit. I have fixed it and created a new pull request #46. Thanks.