search

cartographer-project / point_cloud_viewer

View billions of points in your browser.
Apache License 2.0
339 stars 98 forks source link

Fix octree generation. #203

Closed SirVer closed 5 years ago

SirVer commented 5 years ago

On octree generation, parent nodes are generated by subsampling from their children. The code is checking for all 8 potential children, expecting that the NodeIterator correctly returns NodeNotFound if a node does not exist.

However the OnDiskDataProvider returned std::io::ErrorKind::NotFound instead, which was taken as a hard error, ending octree generation.

SirVer commented 5 years ago

@feuerste Please review, take over and shepherd into master.

feuerste commented 5 years ago

@wally-the-cartographer merge

wally-the-cartographer commented 5 years ago

Merge requested by authorized user feuerste. Merge queue now has a length of 1.