search

cartographer-project / point_cloud_viewer

View billions of points in your browser.
Apache License 2.0
339 stars 98 forks source link

fixing typeroots to include repo as a git subtree #206

Closed catevita closed 5 years ago

catevita commented 5 years ago

small change to allow a correct use of point_cloud_viewer as a submodule in git projects. the same syntax is also in xrays/client

ptal! @feuerste

googlebot commented 5 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

Googlers can find more info about SignCLA and this PR by following this link.

feuerste commented 5 years ago

ok!

You need to navigate to "Files changed", "Review changes", and approve there.

googlebot commented 5 years ago

:frowning_face: Sorry, but only Googlers may change the label cla: yes.