search

cartographer-project / point_cloud_viewer

View billions of points in your browser.
Apache License 2.0
339 stars 98 forks source link

PointCulling Trait and Iterator cleanup #278

Closed catevita closed 5 years ago

catevita commented 5 years ago

The iterator are splitted on -iterator that retrieve nodes -iterator that scan points on a single node

The PointLocation in which the Points that have to be retrieved has been streamlined, the methods contains and intersects are part of the trait PointCulling. This works for an Aabb3, Obb, OrientedBeam and Frustum

catevita commented 5 years ago

still quite a big PR, I tried my best to remove some other additional changes PTAL @nnmm @feuerste

catevita commented 5 years ago

I did some benchmarking running time (./target/release/octree_benchmark ~/octree_marco/ --no-client) on my workstation. Results are quite aligned, typically these

new: real 0m3.662s user 0m3.500s sys 0m0.160s

old real 0m3.563s user 0m3.408s sys 0m0.152s

feuerste commented 5 years ago

Can you please remove the .DS_Store file?

catevita commented 5 years ago

Can you please remove the .DS_Store file?

Indeed it shows up in the list, but it as removed file

feuerste commented 5 years ago

Can you please remove the .DS_Store file?

Indeed it shows up in the list, but it as removed file

Ah, I see, thanks, I overlooked this...

googlebot commented 5 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

googlebot commented 5 years ago

:frowning_face: Sorry, but only Googlers may change the label cla: yes.

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

catevita commented 5 years ago

@wally-the-cartographer merge

catevita commented 5 years ago

@wally-the-cartographer merge

feuerste commented 5 years ago

@wally-the-cartographer merge

catevita commented 5 years ago

@gaschler sorry to bother you, Wally seems to be down again, could you help me merging this branch or pointing to the right person that mantains Wally?

catevita commented 5 years ago

thanks!