search

cartographer-project / point_cloud_viewer

View billions of points in your browser.
Apache License 2.0
339 stars 98 forks source link

Consolidate node layers. #292

Closed feuerste closed 5 years ago

feuerste commented 5 years ago

This moves from a NodeLayer enum to attribute strings, so we are more flexible in the future, what kind of attributes we want to read/write.

nnmm commented 5 years ago

:+1: I also like that we're calling them attributes everywhere now.

feuerste commented 5 years ago

Thanks for reviewing, Caterina and Nikolai!

feuerste commented 5 years ago

@wally-the-cartographer merge

wally-the-cartographer commented 5 years ago

Merge requested by authorized user feuerste. Merge queue now has a length of 1.

wally-the-cartographer commented 5 years ago

Refusing to merge, since the combined checks state is failure

feuerste commented 5 years ago

Thanks for the review Caterina and Nikolai!

feuerste commented 5 years ago

@wally-the-cartographer merge

wally-the-cartographer commented 5 years ago

Merge requested by authorized user feuerste. Merge queue now has a length of 1.