search

cartographer-project / point_cloud_viewer

View billions of points in your browser.
Apache License 2.0
339 stars 98 forks source link

BufReader: buffer size set to 1MB #303

Closed catevita closed 5 years ago

catevita commented 5 years ago

BufReader wraps and impl Read struct in order to optimize the read() calls (calling less often), while caching the contents in an internal buffer. The default size of 8kb is quite tiny for point clouds, 1MB is a quite good limit for a buffer, especially in multi-threaded, multi-buffer implementation.

The benchmark test gives pretty much the same results on local disk, improvements should be noticed acquiring the data from remote.

catevita commented 5 years ago

PTAL @feuerste

feuerste commented 5 years ago

Can you please update the description of this PR and explain its reasoning a bit?

catevita commented 5 years ago

the modifications are not necessary anymore.