search

cartographer-project / point_cloud_viewer

View billions of points in your browser.
Apache License 2.0
339 stars 98 forks source link

Use std::slice::from_ref to prettify code #304

Closed nnmm closed 5 years ago

nnmm commented 5 years ago

This is a handy function that I think all of us overlooked when we made the BatchIterator accept &[Octree]: https://doc.rust-lang.org/std/slice/fn.from_ref.html

nnmm commented 5 years ago

ptal @catevita fyi @feuerste

googlebot commented 5 years ago

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

feuerste commented 5 years ago

@wally-the-cartographer merge