search

cartographer-project / point_cloud_viewer

View billions of points in your browser.
Apache License 2.0
337 stars 98 forks source link

Make batch_iterator not directly depend on octree #315

Closed nnmm closed 5 years ago

nnmm commented 5 years ago

BatchIterator is now based on a new PointCloud trait that can be implemented by S2-based pointclouds in the future. Since impl Trait is disallowed in trait definitions, I removed the type parameter from FilteredPointsIterator and specialized it to only filter by PointCulling's contains method.

I moved the batch_iterator module to the top level as well and renamed intersects to intersects_aabb3, to contrast it with the planned intersects_s2_cell method.

nnmm commented 5 years ago

meow @feuerste fyi @catevita

nnmm commented 5 years ago

ptal @krzesi-mir – Marco and Caterina are out :)

nnmm commented 5 years ago

:dash:

nnmm commented 5 years ago

@wally-the-cartographer merge

nnmm commented 5 years ago

@wally-the-cartographer merge