cartographer-project / point_cloud_viewer

View billions of points in your browser.
Apache License 2.0
339 stars 98 forks source link

Add method to return size of AttributeType #336

Closed catevita closed 5 years ago

catevita commented 5 years ago

PTAL @feuerste @nnmm

nnmm commented 5 years ago

Could you describe what this will be used for?

catevita commented 5 years ago

I am checking that size of files written just handling everything as a bytestream matches the number of points * attribute_size, that's why I need it

feuerste commented 5 years ago

I need this, too, to compute byte offsets for the number of already written points, see #337 Which one do you prefer?

nnmm commented 5 years ago

I'd go with this one, since size_of also returns usize, but name it num_bytes or size_of.

feuerste commented 5 years ago

:dash: