search

cartographer-project / point_cloud_viewer

View billions of points in your browser.
Apache License 2.0
339 stars 98 forks source link

Introduce batches for all iterators. #356

Closed feuerste closed 5 years ago

feuerste commented 5 years ago

This PR changes all iterators used by the point cloud client to return PointsBatches instead of Points. This enables reading of all attributes by the client instead of just position, color, and intensity.

Please review with Hide whitespace changes turned on.

nnmm commented 5 years ago

Actually it seems like the pts format does contain the number of points, which would mean we might be able to make NumberOfPoints return just usize: https://github.com/patrikhuber/eos/blob/master/examples/data/image_0010.pts

feuerste commented 5 years ago

Actually it seems like the pts format does contain the number of points, which would mean we might be able to make NumberOfPoints return just usize: https://github.com/patrikhuber/eos/blob/master/examples/data/image_0010.pts

Are you sure that this is the correct format? Did you find an example containing points divided into 7 parts (3 position, 1 unknown, 3 rgb)? How about just entirely removing pts reading? (Just created a PR for this, see #360)

feuerste commented 5 years ago

@nnmm The pts iterator was entirely removed, ptal!