search

cartographer-project / point_cloud_viewer

View billions of points in your browser.
Apache License 2.0
339 stars 98 forks source link

Set S2 cell level to 16 #376

Closed nnmm closed 5 years ago

nnmm commented 5 years ago

Based on experiments with point cloud building performance, this level better balances not overfetching with avoiding overhead from too small cells.

nnmm commented 5 years ago

ptal @feuerste @catevita

catevita commented 5 years ago

shall we put some of the result and timings somewhere into this pr or ticket? were it useful if the level was customizable -at least until the complete toolchain is active? I would also be interested on what the cell size means downwards: e.g. computing frustums in such big cells, or the need to sample from those.

feuerste commented 5 years ago

Timings would definitely be helpful.. you have them somewhere anyways, right?

nnmm commented 5 years ago

Making the level customizable is not super straightforward since the NodeWriter trait mandates the new() method, which doesn't have custom parameters like this one.

nnmm commented 5 years ago

The timings are of course depending on bandwith, the tool used for uploading the files etc., but in my case for a tiny test set they were:

73min for level 20 2 min for level 16