cartographer-project / point_cloud_viewer

View billions of points in your browser.
Apache License 2.0
337 stars 98 forks source link

xray merger interface #436

Closed krzesi-mir closed 4 years ago

krzesi-mir commented 4 years ago
$ cargo run --bin merge_xray_quadtrees -- --output_directory /mnt/disk . ../ a/ a/b/c/
[xray/src/bin/merge_xray_quadtrees.rs:21] args = CommandlineArguments {
    output_directory: "/mnt/disk",
    input_directories: [
        ".",
        "../",
        "a/",
        "a/b/c/",
    ],
}
thread 'main' panicked at 'not implemented', xray/src/bin/merge_xray_quadtrees.rs:22:5
$ cargo run --bin merge_xray_quadtrees -- --help
merge_xray_quadtrees 0.1.0
Merge partial xray quadtrees. We assume that the root of each quadtree belongs to the same level of the final quadtree

USAGE:
    merge_xray_quadtrees --output_directory <output-directory> [input-directories]...

FLAGS:
    -h, --help       Prints help information
    -V, --version    Prints version information

OPTIONS:
        --output_directory <output-directory>
            Directory where to write the merged quadtree. Does *not* have to be disjoint from input_directories

ARGS:
    <input-directories>...    Directories with, possibly multiple, partial xray quadtrees
krzesi-mir commented 4 years ago

With new arguments:

$ cargo run --bin merge_xray_quadtrees -- --help
merge_xray_quadtrees 0.1.0
Merge partial xray quadtrees. We assume that the root of each quadtree belongs to the same level of the final quadtree

USAGE:
    merge_xray_quadtrees [OPTIONS] --output-directory <output-directory> [input-directories]...

FLAGS:
    -h, --help       Prints help information
    -V, --version    Prints version information

OPTIONS:
        --output-directory <output-directory>
            Directory where to write the merged quadtree. Does *not* have to be disjoint from input_directories

        --tile-background-color <tile-background-color>    Tile background color [default: white]
        --tile-size <tile-size>                            Tile size [default: 256]

ARGS:
    <input-directories>...    Directories with, possibly multiple, partial xray quadtrees
krzesi-mir commented 4 years ago

Or do you prefer to have both output_directory and input_directories as positional arguments? i.e.

$ cargo run --bin merge_xray_quadtrees -- --help
merge_xray_quadtrees 0.1.0
Merge partial xray quadtrees. We assume that the root of each quadtree belongs to the same level of the final quadtree

USAGE:
    merge_xray_quadtrees [OPTIONS] <output-directory> [input-directories]...

FLAGS:
    -h, --help       Prints help information
    -V, --version    Prints version information

OPTIONS:
        --tile-background-color <tile-background-color>    Tile background color [default: white]
        --tile-size <tile-size>                            Tile size [default: 256]

ARGS:
    <output-directory>        Directory where to write the merged quadtree. Does *not* have to be disjoint from
                              input_directories
    <input-directories>...    Directories with, possibly multiple, partial xray quadtrees
krzesi-mir commented 4 years ago

Or

$ cargo run --bin merge_xray_quadtrees -- --help
merge_xray_quadtrees 0.1.0
Merge partial xray quadtrees. We assume that the root of each quadtree belongs to the same level of the final quadtree

USAGE:
    merge_xray_quadtrees [OPTIONS] --output-directory <output-directory>

FLAGS:
    -h, --help       Prints help information
    -V, --version    Prints version information

OPTIONS:
        --input-directory <input-directories>...           Directories with, possibly multiple, partial xray quadtrees
        --output-directory <output-directory>
            Directory where to write the merged quadtree. Does *not* have to be disjoint from input_directories

        --tile-background-color <tile-background-color>    Tile background color [default: white]
        --tile-size <tile-size>                            Tile size [default: 256]
krzesi-mir commented 4 years ago

Thanks for the review!