Fix matrix initialization. - Githubissues

cartographer-project / point_cloud_viewer

View billions of points in your browser.

Apache License 2.0

339 stars 98 forks source link

Fix matrix initialization. #466

Closed feuerste closed 4 years ago

feuerste commented 4 years ago

https://github.com/cartographer-project/point_cloud_viewer/pull/415/files#diff-fedc635549c49a1867cf6b18f648e6b8R158-R165 introduced a bug when initializing a matrix from all values. cgmath takes column major values, while nalgebra takes row major ones.

feuerste commented 4 years ago

FYI @dudv

feuerste commented 4 years ago

Thanks for your review!