search

cartr / homebrew-qt4

Homebrew tap for Qt4 and dependent formulae on Sierra
BSD 2-Clause "Simplified" License
105 stars 42 forks source link

Fix plugin and import directories (closes #25) #26

Closed cartr closed 7 years ago

cartr commented 7 years ago

This change fixes the discrepancy reported in #25 by telling Qt to install its plugins and imports to the directory that qmake says they're installed at. This way, external software that depends on these paths won't break when qt@4's version number changes.

cartr commented 7 years ago

I've tested this locally and it appears to resolve the issue. The plugins and imports paths reported by qmake -query now exist and contain the appropriate files.

@bblacey, can you confirm this solves the cmake problem you were experiencing?

bblacey commented 7 years ago

I can do that but it will take me a while to rebuild qt4 from source. Stand by.

bblacey commented 7 years ago

Here is the test that is underway.

export HOMEBREW_DEVELOPER="1"
git tap --full cartr/qt4
cd $(brew --prefix)/Homebrew/Library/Taps/cartr/homebrew-qt4
git fetch origin pull/26/head:pr-26
git checkout pr-26
brew install --build-from-source cartr/qt4/qt@4
bblacey commented 7 years ago

@cartr - Fix confirmed! Once I installed Qt 4 using the formula on this pull request, I rebuilt FreeCAD, created the app bundle and ran all the build tests. Looks good! Thanks for the quick response. How long will it take to produce the bottles for Yosemite?

cartr commented 7 years ago

Great! Thanks for the detailed report and help with the fix. Bottles will likely take around 40 minutes to be built, uploaded, and added to the repo. After that, I'll merge this PR and we should be good to go.

bblacey commented 7 years ago

I think there is a typo in the auto-bottler Travis config - checkout this line https://github.com/cartr/qt4-autobottler/blob/3479acf30dc4d05eecb5a6a4eee242535147e1a7/.travis.yml#L7

cartr commented 7 years ago

@bblacey That osx_image line is unindented because it defines the "default" image for the build. Travis creates a single default job with that image, and then two additional jobs are created by the matrix section. You can see the three jobs here. It's a bit hard-to-read, I admit, but I'll be able to fix that once https://github.com/travis-ci/travis-ci/issues/7587 is fixed.

The build ended up failing for an entirely different reason, though. It turns out that without a script section in .travis.yml, Travis tries and fails to run ./configure && make && make test. Now that that's fixed, bottles should be ready an hour from now.