search

cartr / homebrew-qt4

Homebrew tap for Qt4 and dependent formulae on Sierra
BSD 2-Clause "Simplified" License
105 stars 42 forks source link

qt@4: Patch to avoid compilation issue involving QFixed #54

Closed cartr closed 6 years ago

cartr commented 6 years ago

Closes #53.

@jdknox, can you verify that this fixes the issue for you?

jdknox commented 6 years ago

Sorry, I was out of town and didn't get a chance to test this earlier.

In the future, what's the best way to test patch branches? I tried to clone your repo and git checkout the qfixed-fix branch, but I don't know how to get brew to use the new patch.

cartr commented 6 years ago

@jdknox No worries at all! The formula built successfully on High Sierra, so I figured it was fixed and merged your patch. Please do let me know if it's still broken for you.

I usually test branches by cd-ing to Homebrew's copy of the repo and checking out the branch there. You can do that with the following commands:

$ cd /usr/local/Homebrew/Library/Taps/cartr/homebrew-qt4
$ git config --add remote.origin.fetch "+refs/heads/*:refs/remotes/origin/*" && git fetch
$ git checkout branch-name-goes-here
$ brew install qt@4 #or brew update or whatever

(That git config line is needed because by default, Homebrew only fetches the master branch of a tap.)