cartr / homebrew-qt4

Homebrew tap for Qt4 and dependent formulae on Sierra
BSD 2-Clause "Simplified" License
105 stars 42 forks source link

Fix Q_OBJECT warnings on ICC #58

Closed cartr closed 6 years ago

cartr commented 6 years ago

Closes #57.

The original version of the patch accounts for the fact that ICC pretends to be GCC. This PR revises the patch to account for ICC pretending to be Clang. (The Qt 4 source includes similar checks.)

@swordencao, I don't have access to a copy of ICC to test this locally. Can you please check if this fixes your issue?

swordencao commented 6 years ago

Test with no error, please merge, thanks.