search

carvel-dev / carvel

Carvel provides a set of reliable, single-purpose, composable tools that aid in your application building, configuration, and deployment to Kubernetes. This repo contains information regarding the Carvel open-source community.
https://carvel.dev/
Apache License 2.0
374 stars 111 forks source link

Add deadcode/unused linters to repositories #157

Open aaronshurley opened 3 years ago

aaronshurley commented 3 years ago

Why

With the addition of linting tools, we should continue adding on additional linters to assure better code quality. Some of the more important linters we can add are deadcode/unused. These linters help detect unused code in go projects.

As part of enabling these linters, we should also remove any unused source code from kapp, imgpkg, kbld, and ytt.

As a Carvel maintainer I want linters enabled that check for unused code So that I can avoid confusion/having to maintain code that is not being used

Acceptance Criteria

Scenario:

Given I run the linter.sh script for the repos listed above Then I see no violations from (deadcode) or (unused)

Additional Infomation

microwavables commented 3 years ago

moved from /carvel-community to /carvel as we are merging the two into one