carvel-dev / carvel

Carvel provides a set of reliable, single-purpose, composable tools that aid in your application building, configuration, and deployment to Kubernetes. This repo contains information regarding the Carvel open-source community.
https://carvel.dev/
Apache License 2.0
374 stars 111 forks source link

Fix comment in vendir-spec.md regarding path #542

Closed coreyti closed 2 years ago

coreyti commented 2 years ago

Before this change, the comment stated:

path is relative to vendir.yml location

That's not actually true. The path is actually relative to where vendir is executed. For example:

vmwclabot commented 2 years ago

@coreyti, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

vmwclabot commented 2 years ago

@coreyti, we have received your signed contributor license agreement. It will be reviewed by VMware shortly. Another comment will be added to the pull request to notify you when the merge can proceed.

vmwclabot commented 2 years ago

@coreyti, VMware has approved your signed contributor license agreement.

pivotaljohn commented 2 years ago

Excellent catch, @coreyti.

Thank you for taking the time to investigate and fix the docs! Few things are more frustrating than when the documentation is flat out wrong. 🙌🏻