search

carvel-dev / carvel

Carvel provides a set of reliable, single-purpose, composable tools that aid in your application building, configuration, and deployment to Kubernetes. This repo contains information regarding the Carvel open-source community.
https://carvel.dev/
Apache License 2.0
373 stars 110 forks source link

Document FORCE_COLOR environment variable #581

Closed gberche-orange closed 1 year ago

gberche-orange commented 1 year ago

Closes partially https://github.com/vmware-tanzu/carvel-kapp/issues/632

vmwclabot commented 1 year ago

@gberche-orange, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

cppforlife commented 1 year ago

@gberche-orange thanks for adding this in. would you mind moving into kapp directory instead of kapp-controller.

praveenrewar commented 1 year ago

would you mind moving into kapp directory instead of kapp-controller.

I think having the kctrl example in kapp-controller directory makes sense. We could probably have a kapp example added as well (to the kapp directory) ?

gberche-orange commented 1 year ago

thanks @cppforlife and @praveenrewar

I've added two commits to also document FORCE_COLOR in the kapp documentation, and refined a bit the kctrl example command.

vmwclabot commented 1 year ago

@gberche-orange, we have received your signed contributor license agreement. It will be reviewed by VMware shortly. Another comment will be added to the pull request to notify you when the merge can proceed.

vmwclabot commented 1 year ago

@gberche-orange, VMware has approved your signed contributor license agreement.