carvel-dev / kapp-controller

Continuous delivery and package management for Kubernetes.
https://carvel.dev/kapp-controller
Apache License 2.0
260 stars 99 forks source link

Fix error handling in kctrl package release command #1552

Closed goshkis closed 1 week ago

goshkis commented 2 months ago

What steps did you take:

❯ kctrl package release --chdir "carvel-packages/my-package-name" --version "0.0.1" --yes --repo-output ../../package-repository

[...skipped...]
Building images and resolving references
        | $ ytt -f /var/folders/t2/ypy2b3v55g163rqdg934k2pr0000gp/T/kapp-controller-fetch-template-[...skipped...]
An imgpkg bundle consists of all required manifests bundled into an OCI image.
This image is pushed to a registry and consumed by the package.
Pushing imgpkg bundle
        | $ imgpkg push -b [...skipped...]:build-1714175591 -f ./bundle-[...skipped...]:build-1714175591-2627758157 --tty=true
        | dir: .
        | dir: .imgpkg
        | file: .imgpkg/images.yml
[...skipped...]
        | Pushed '[...skipped...]@sha256:4525b5ee06.......41dcf7801'
        | Succeeded

Succeeded

❯ ls package-repository/
pkgrepo-build.yml

^^^ No package content

What happened: kctrl package release ... --repo-output ... command is silently ignoring errors from releaseResources function. Say, if incompatible ytt version is installed, this command will not yield any errors but no content will be written to the destination.

What did you expect: Expected error in this specific environment:

        | Succeeded

kctrl: Error: exit status 1: ytt:
  Error: unknown flag: --data-values-schema-inspect

Anything else you would like to add: n/a

Environment: n/a


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible" 👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.