carvel-dev / kapp-controller

Continuous delivery and package management for Kubernetes.
https://carvel.dev/kapp-controller
Apache License 2.0
260 stars 99 forks source link

Add partial support for DownwardsAPI with kctrl package release #1580

Closed 100mik closed 2 days ago

100mik commented 2 weeks ago

What this PR does / why we need it:

This PR allows Packages using DownwardsAPI to obtain kubernetesAPIs or kubernetesVersion by feeding a false value. However this value cannot be reliably used to introduce images in the template step for the time being. This does not block users who are not conditionally introducing images based on these parameters. It mocks CoreV1 client calls made by GetServiceAccountToken

Which issue(s) this PR fixes:

Partially fixes #1523

Does this PR introduce a user-facing change?

Additional Notes for your reviewer:

Review Checklist:

Additional documentation e.g., Proposal, usage docs, etc.:

We should document that using `kappControllerVersion` with DownwardAPI can lead to failures while releasing packages