Open GrahamDumpleton opened 2 years ago
Hi team, I would like to take up this issue.
hi @hemakshis ! Thanks for showing interest in taking this on.
This might be a helpful start:
Let us know how we can support you! You might also find our dev docs a good place to start on just getting this up and running.
@GrahamDumpleton could you pls provide the file where I need to commit changes
@sarthaksarthak9 I have no idea as I don't know how kubebuilder is configured to specify such a constraint.
Describe the problem/challenge you have
Both
serviceAccountName
andcluster
properties of theApp
CR are marked as optional. Anyone not understanding that one or the other is required may not even add either. When neither is added, then theApp
CR is still accepted and you end up with an error which you have to look in theApp
CR status of:Further, when trying to delete the
App
in this situation it fails with it eventually exiting with the error:resulting in you needing to manually delete the finalizer from the
App
resource.The latter problem relates to issue https://github.com/vmware-tanzu/carvel-kapp-controller/issues/416.
Describe the solution you'd like
The CR definition should enforce that one or the other of
serviceAccountName
andcluster
is required so that attempting to create anApp
CR with neither is rejected immediately.My understanding is that this can be achieved in the CR schema by using:
Anything else you would like to add:
Having to look into the status of the
App
CR is non obvious so anything that avoids getting into that situation in the first place is a bonus. So failing early at the point of creating theApp
is better.Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible" 👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.