Open GrahamDumpleton opened 3 years ago
--json is incompatible with interactive UI (that's what this error is trying to message panic: Cannot ask for confirmation in JSON UI
). you either have to use -y for the full deploy or --diff-run since it ends before confirmation prompt pops in.
If the flags are incompatible, or -y
is required, the correct thing to do is to show that message and not a json rendered output and a panic.
Cannot ask for confirmation in JSON UI. Either use `-y` flag or remove `--json` format
This should be the only output. It should not even try to deploy and fail.
We may have look at making changes generically in the library used: https://github.com/cppforlife/go-cli-ui
What steps did you take:
Create an
example.yaml
file containing:Run:
What happened:
It appeared to crash and generate a Golang stack trace.
What did you expect:
Am not sure. I was trying to work out what the
--json
option actually did when it occurred, so not sure if this is expected and normal, but it sort of looks wrong.Anything else you would like to add:
Nope.
Environment:
Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible" 👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.
cc @jorgemoralespou