search

carvel-dev / kapp

kapp is a simple deployment tool focused on the concept of "Kubernetes application" — a set of resources with the same label
https://carvel.dev/kapp
Apache License 2.0
929 stars 110 forks source link

HPA: keep the server chosen values per default #473

Closed universam1 closed 2 years ago

universam1 commented 2 years ago

Thank you for providing a great tool!

Describe the problem/challenge you have

The fix to add custom rebaseRules to “prefer” server chosen value for spec.replicasUsers on each repo is often unknown or forgotten by developers. It requires additional training and makes it harder for the developers to use Kapp for their deployments.

Describe the solution you'd like

Kapp should detect when a deployment does not explicitly define replicas and thus keep the server chosen value without resetting it. Alternatively, apply the above config "fix" if a HPA is part of the app.

Similar to https://github.com/vmware-tanzu/carvel-kapp/issues/80#issuecomment-596640209

rohitagg2020 commented 2 years ago

Thank you for the encouraging words @universam1

rohitagg2020 commented 2 years ago

@universam1 I would like to understand more about this scenario. Can we hop on a jump a zoom call if possible?