search

carvel-dev / release-scripts

contains scripts for releasing carvel tools
Apache License 2.0
4 stars 3 forks source link

Introduce inclusive naming check github action #27

Closed aaronshurley closed 1 year ago

aaronshurley commented 1 year ago

Based upon feedback on https://github.com/vmware-tanzu/carvel/pull/595 (feedback in slack).

aaronshurley commented 1 year ago

As @neil-hickey has mentioned, I think we can use the Github Action for woke. This will make things like running the command only for changed files a lot easier.

I'm not opposed to using a GitHub Action but generally, our guidance has been using GitHub Actions from verified developers (which this one isn't). Additionally, this GHA hasn't been updated in over two years so I'm not sure if this GHA is maintained.

Is this a PR-blocking topic for y'all? @praveenrewar @neil-hickey

aaronshurley commented 1 year ago

@praveenrewar mind completing your review with your thoughts on the next steps (such as requesting changes or approval)? Thanks!

aaronshurley commented 1 year ago

I chatted with @neil-hickey about this and he's fine with the current approach. In the spirit of moving things along, I'm going to merge but we can always re-visit this topic if it's a sticking point for folks.

praveenrewar commented 1 year ago

@aaronshurley Sorry I missed this because I was travelling back from Bangalore. I just went through the updates on this and I am good with the changes :)