carvel-dev / secretgen-controller

secretgen-controller provides CRDs to specify what secrets need to be on Kubernetes cluster (to be generated or not)
Apache License 2.0
178 stars 29 forks source link

secretgen-controller should allow configuration of the metrics server port #509

Closed douglas-c closed 9 months ago

douglas-c commented 10 months ago

Describe the problem/challenge you have Running secretgen-controller in a deployment with hostNetwork=true can lead to the default metrics server port 8080 conflicting with other applications running on that node.

Describe the solution you'd like We would like the metrics server port to be configurable, at least via container args if not through something more formal like a ConfigMap.

Anything else you would like to add There was an identical issue with kapp-controller, see kapp-controller/issues/394 which was fixed with kapp-controller/pull/404. A similar fix would work for our use case as well.


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible" 👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you would like to work on this issue.