Upgrade Node 16 to Node 20

carvel-dev / setup-action

Github Action for setting up Carvel apps (ytt, kbld, kapp, kctrl, kwt, imgpkg and vendir)

Apache License 2.0

16 stars 5 forks source link

Upgrade Node 16 to Node 20 #300

Closed ThomasVitale closed 11 months ago

ThomasVitale commented 11 months ago

Upgrade the action to use Node 20 instead of Node 16.
Migrate from @zeit/ncc to @vercel/ncc package because the former has been out of maintenance for 3 years and a transition to the latter is recommended. Change done here because @zeit/ncc doesn't provide support for Node 20.

Fixes gh-299

jbrunton commented 11 months ago

Thanks for the PR, @ThomasVitale!

I see the build is failing. I have a hunch this is unrelated and I'll check this now.

I also note that for Enterprise users with self-hosted runners, Node 20 support was only added in August (https://github.com/actions/runner/releases/tag/v2.308.0) so I suspect this may be a breaking change for some. I think when we merge this the next build should be called v2. No action required in this PR, but just a reminder to myself (and an FYI to others).

jbrunton commented 11 months ago

@ThomasVitale : Could you do me a favor to fix the build? Either merge, cherry-pick or copy and paste the changes from https://github.com/carvel-dev/setup-action/pull/301 onto your branch?

This PR needs that fix to pass, but my PR also needs (some of) the dependency upgrades in your PR to pass. Between them they should do the job.

ThomasVitale commented 11 months ago

@jbrunton thanks for the review. Since my branch is in a fork, I couldn't cherry-pick your commit fixing the tests, so I copied the fix. I hope that's ok.

I agree about bumping the major version for the new release since it could be a breaking change.

jbrunton commented 11 months ago

@ThomasVitale : thank you, that all looks good. I'll merge this and create a new version.