search

carvel-dev / terraform-provider-carvel

Carvel Terraform provider with resources for ytt and kapp to template and deploy to Kubernetes
Apache License 2.0
42 stars 9 forks source link

Provider swallows kapp errors during the diff phase #11

Closed braunsonm closed 3 years ago

braunsonm commented 3 years ago

What steps did you take: If you accidentally provide an incorrect kapp Config, the kapp command will present an error. However this is swallowed with the provider and does not report an error.

What happened: Instead of seeing the error with kapp in the diff section, it just says that there is no change.

What did you expect: The error should be presented and the apply stopped.

StevenLocke commented 3 years ago

Thanks for the report, this definitely feels like a bug! Does this happen with every invalid kapp config? If not, are you able to provide a quick example of an invalid config which causes the terraform-provider to swallow the error?

You noted that you expected the apply to stop, in the cases where the invalid config error is swallowed, does kapp make any changes to your cluster?

braunsonm commented 3 years ago

Hey @StevenLocke the issue is actually from this: https://github.com/vmware-tanzu/terraform-provider-carvel/issues/14

Initially I had thought it was the kapp error about the diff changing but I think it's actually just this internal terraform error. Closing in favor of #14