search

carvel-dev / vendir

Easy way to vendor portions of git repos, github releases, helm charts, docker image contents, etc. declaratively
https://carvel.dev/vendir
Apache License 2.0
276 stars 49 forks source link

helm chart vendoring should also allow for vendoring dependencies #208

Closed reegnz closed 1 year ago

reegnz commented 1 year ago

Describe the problem/challenge you have I'm vendoring some helm charts with vendir from bitnami, eg. bitnami/external-dns. These charts tend to have a dependency to bitnami-common to get some helper functions.

Problem is, these dependencies are not vendored, so I cannot use the vendored chart in an air-gapped (offline) environment.

Describe the solution you'd like When vendoring helm charts, vendir should also vendor dependencies, if instructed explicitly in the config to do so.

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible" 👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

reegnz commented 1 year ago

I might have been mistaken, on a completely empty setup I managed to sync things properly. My helm executable was helm2 not helm3, and that might have caused my problem.