carvel-dev / vendir

Easy way to vendor portions of git repos, github releases, helm charts, docker image contents, etc. declaratively
https://carvel.dev/vendir
Apache License 2.0
276 stars 49 forks source link

vendir doesn't load correct keychains when provided with the environment variables #209

Closed joaopapereira closed 1 year ago

joaopapereira commented 1 year ago

What steps did you take: When sync an image while trying to use the Credentials Helpers from the Azure/AWS/GCP are failing with 401 error

What happened: Fails to pull images using the Credentials helpers

What did you expect: That vendir would be able to use the cred helpers from imgpkg to download the images

Anything else you would like to add: The environment variable IMGPKG_ACTIVE_KEYCHAINS is not being respected because it is not taken into account when creating the registry options in https://github.com/vmware-tanzu/carvel-vendir/blob/develop/pkg/vendir/fetch/image/imgpkg.go#L157

Environment:


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

πŸ‘ "I would like to see this addressed as soon as possible" πŸ‘Ž "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help work on this issue.