search

carvel-dev / vendir

Easy way to vendor portions of git repos, github releases, helm charts, docker image contents, etc. declaratively
https://carvel.dev/vendir
Apache License 2.0
269 stars 47 forks source link

add option for skipping SSL verification #265

Closed vmunishwar closed 9 months ago

vmunishwar commented 1 year ago

To fix the issue - https://github.com/carvel-dev/vendir/issues/260

kumaritanushree commented 1 year ago

Changes looks good to me. It will be good if we can add test for the same if possible.

vmunishwar commented 9 months ago

@joaopapereira @kumaritanushree - I have tested the changes and they are working fine on a local gitlab server created with a self signed certificate

vmunishwar commented 9 months ago

Steps to reproduce locally:

  1. Use docker image at https://github.com/danieleagle/gitlab-https-docker/tree/master to start local git lab server. Create a repo.
  2. Create self signed certificate using openssl and configure with the server
  3. Test vendir sync - It should give an error 'SSL certificate problem: self signed certificate'
  4. Tested the fix by adding skipSslVerfication: true. There is no error and repo gets cloned successfully.
kumaritanushree commented 9 months ago

LGTM