carvel-dev / vendir

Easy way to vendor portions of git repos, github releases, helm charts, docker image contents, etc. declaratively
https://carvel.dev/vendir
Apache License 2.0
268 stars 46 forks source link

Vendir directory sync ignores overlapping paths on directories #323

Closed fritzduchardt closed 4 months ago

fritzduchardt commented 7 months ago

What steps did you take: I am running this vendir.yml with two directories that define the same root path:

kind: Config
directories:
- path: vendor
  contents:
  - path: dir1/output
    directory:
      path: ./local-dir
- path: vendor
  contents:
  - path: dir2/output
    directory:
      path: ./local-dir-2

What happened: The second directory overwrites the first in the final output directory. Only dir2 appears in the final output directory.

What did you expect: I would either expect an overlapping path error message, as with overlapping paths within the same directory, or I would expect both dirs to appear in the final output directory.

Environment:


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

πŸ‘ "I would like to see this addressed as soon as possible" πŸ‘Ž "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

github-actions[bot] commented 6 months ago

This issue is being marked as stale due to a long period of inactivity and will be closed in 5 days if there is no response.

renuy commented 6 months ago

Another PR has been added for resolving similar issue https://github.com/carvel-dev/vendir/pull/343 This needs discussion to decide on the approach. To be discussed in community meeting 1/10/2024

kumaritanushree commented 4 months ago

Fix has been done as part of PR https://github.com/carvel-dev/vendir/pull/343