carvel-dev / vendir

Easy way to vendor portions of git repos, github releases, helm charts, docker image contents, etc. declaratively
https://carvel.dev/vendir
Apache License 2.0
281 stars 50 forks source link

Adding the ability to configure imgpkg timeout #344

Closed alexbarbato closed 8 months ago

alexbarbato commented 9 months ago

Potentially closes #329

Looking for feedback if this solution doesn't appear right to you all. Thanks!

alexbarbato commented 9 months ago

Doh, i do that everytime. Thanks! Updated @joaopapereira

praveenrewar commented 9 months ago

@alexbarbato The DCO check is still failing 😅

alexbarbato commented 9 months ago

git commit -S

@joaopapereira trying to trick me :P I think it's -s

Should work now, but please let me know if I'm still goofing something up!

praveenrewar commented 8 months ago

@joaopapereira trying to trick me :P I think it's -s

Lol, yes, it should be -s.

alexbarbato commented 8 months ago

@joaopapereira anything you need here to merge?