search

carvel-dev / vendir

Easy way to vendor portions of git repos, github releases, helm charts, docker image contents, etc. declaratively
https://carvel.dev/vendir
Apache License 2.0
268 stars 46 forks source link

PrivateKey with or without extra char as newline will be accepted #349

Closed kumaritanushree closed 5 months ago

kumaritanushree commented 6 months ago

fix https://github.com/carvel-dev/vendir/issues/350

joaopapereira commented 6 months ago

Is there any kind of test that we can do to ensure that we do not break this in the future? If not we should add a comment to that line to explain why that new line is there

rohitagg2020 commented 5 months ago

LGTM

kumaritanushree commented 5 months ago

Is there any kind of test that we can do to ensure that we do not break this in the future? If not we should add a comment to that line to explain why that new line is there

Added comment as of now as to add e2e test we will required to maintain dummy private repo and private key to access that. I think comment should be fine.