search

carvel-dev / vendir

Easy way to vendor portions of git repos, github releases, helm charts, docker image contents, etc. declaratively
https://carvel.dev/vendir
Apache License 2.0
281 stars 50 forks source link

can't install on old fedora #384

Open jkremser opened 4 months ago

jkremser commented 4 months ago

can't install on Fedora (pretty old one (35), but still)

I am missing the shasum binary that's required by the installation script. I have sha1sum binary present, but it has slightly different contract, so that even if I alias or symlink the shasum -> sha1sum, it can't pass the followin check:

 shasum -v 1>/dev/null 2>&1 || (echo "Missing shasum binary" && exit 1)

(which is present in your install script)

sha1sum uses either sha1sum --version or sha1sum --v

sha1sum --v
sha1sum (GNU coreutils) 8.32
Copyright (C) 2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

sha1sum -v
sha1sum: invalid option -- 'v'
Try 'sha1sum --help' for more information.

I'd contribute and make the script working, but it can't be found in this repo.

<3

praveenrewar commented 4 months ago

Hey @jkremser! Thank you so much for opening the issue and willing to contribute. The scripts are in https://github.com/carvel-dev/carvel, and we have an existing similar issue present there. We would be happy to review a PR if you want to contribute a fix ❤️

joaopapereira commented 4 months ago

For a pointer, this script is autogenerated so any change would need to be done in https://github.com/carvel-dev/release-scripts/blob/main/scripts/install_sh/install.sh.txt