"Full Screen" on Playground does not expand

carvel-dev / ytt

YAML templating tool that works on YAML structure instead of text

https://carvel.dev/ytt

Apache License 2.0

1.68k stars 137 forks source link

"Full Screen" on Playground does not expand #272

Closed pivotaljohn closed 2 years ago

pivotaljohn commented 3 years ago

What steps did you take:

https://carvel.dev/ytt#playground
Click on the "Full Screen" button

What happened:

👍 other elements on the page went away
👎 the size of the content area did not change

What did you expect: That the content area would expand to fill the document/window.

StevenLocke commented 3 years ago

Works for me! What's that? Your monitor is wider than 980px? Preposterous :D

Reproduced on my machine. Agreed, we should allow the content to grow.

Looks like we're limiting the width in the .content .playground-wrapper css. It's hopefully easy enough to add a more specific selector (with the playground-expanded class incorporated) to change the width.