Fix ytt formatting issue on colons in multiline strings

carvel-dev / ytt

YAML templating tool that works on YAML structure instead of text

https://carvel.dev/ytt

Apache License 2.0

1.66k stars 135 forks source link

Fix ytt formatting issue on colons in multiline strings #856

Closed fritzduchardt closed 1 year ago

fritzduchardt commented 1 year ago

Closes #847

sethiyash commented 1 year ago

Hi @fritzduchardt Thanks for the PR. We will review this on priority.

fritzduchardt commented 1 year ago

@sethiyash sorry, I accidentally retriggered re-review. Do you have a means to ping @100mik and @vmunishwar to get this merged?

sethiyash commented 1 year ago

Hi @fritzduchardt, @vmunishwar is already looking into it. As the changes were made in internal/yaml.v2 package we want to just make sure it will not add any breaking changes.

vmunishwar commented 1 year ago

Hi @fritzduchardt, Thank you for working on this issue, we really appreciate the work you have done to fix this. However, this seems to be an issue present in yaml.v2 library which is used in ytt and also we verified that this issue is present in yaml.v3 library. It would be nice if we can raise this PR in API v2 of the yaml package for Go.