search

carvel-dev / ytt

YAML templating tool that works on YAML structure instead of text
https://carvel.dev/ytt
Apache License 2.0
1.66k stars 135 forks source link

don't modify input when converting to orderedmap #870

Closed notoriaga closed 6 months ago

notoriaga commented 1 year ago

I'm integrating with ytt as a library and noticed that when I convert an object to an orderedmap.Map the input object gets modified. I'm not sure if that's intended but right now it requires me to deepcopy the input before converting which is a little unfortunate.

prembhaskal commented 7 months ago

go: carvel.dev/ytt/pkg/orderedmap tested by carvel.dev/ytt/pkg/orderedmap.test imports github.com/vmware-tanzu/carvel-ytt/pkg/orderedmap: no required module provides package github.com/vmware-tanzu/carvel-ytt/pkg/orderedmap; to add it: go get github.com/vmware-tanzu/carvel-ytt/pkg/orderedmap Error: Process completed with exit code 1.

@notoriaga I think commit should be rebased because we recently changes the module name to carvel.dev/ytt

notoriaga commented 7 months ago

go: carvel.dev/ytt/pkg/orderedmap tested by carvel.dev/ytt/pkg/orderedmap.test imports github.com/vmware-tanzu/carvel-ytt/pkg/orderedmap: no required module provides package github.com/vmware-tanzu/carvel-ytt/pkg/orderedmap; to add it: go get github.com/vmware-tanzu/carvel-ytt/pkg/orderedmap Error: Process completed with exit code 1.

@notoriaga I think commit should be rebased because we recently changes the module name to carvel.dev/ytt

Ahh I see, thanks!

prembhaskal commented 7 months ago

LGTM @100mik @cppforlife Please take a look.