search

carviaso / google-checkout-dotnet-sample-code

Automatically exported from code.google.com/p/google-checkout-dotnet-sample-code
0 stars 0 forks source link

No logging of any kind, despite config file entries and a Log class!! #59

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The linked O'Reilly article suggests that you always "log all XML", but there 
is NO LOGGING OF ANY KIND, not even ERRORS(!) much less tracing of XML messages 
at least in DEBUG builds.  There is a Log class with Err() and Debug() log 
calls, AND very noticeable configuration entries for Logging and LogDirectory, 
but none of this is currently used anywhere within the GCheckout.DLL sources! 
Apparently this was intended for use by client code only?  Or, maybe just not 
implemented yet?  Very strange.

What steps will reproduce the problem?
1. Just run any transactions and notice no trace or debug logs.
2. Cause any errors and notice no error logs.

What is the expected output? What do you see instead?
Something showing up in the log directory that is so obviously configured in 
the web.config file entry.

What version of the product are you using? On what operating system?
2.5.0.5a GCheckout.dll .NET assembly

Original issue reported on code.google.com by kbeck...@cox.net on 14 Sep 2011 at 1:54

GoogleCodeExporter commented 9 years ago 
What logging framework would you like?

Original comment by joseph.f...@gmail.com on 15 Sep 2011 at 7:53

GoogleCodeExporter commented 9 years ago 
No framework, just logging of any possible errors or problems using the already 
existing (but unused) Log.Err() call.
Also, (as suggested by the O'Reilly article) logging of the XML 
request/responses to Google Checkout.  Ideally, this would be something that 
could be turned off, but it should probably be on by default.  Also, it should 
probably go in a separate file, such as 'trace.txt' or 'XML_Log.txt' instead of 
the 'errors.txt' used for errors.
Perhaps putting everything (errors and traces) in a 'Log.YYYY.MM.txt' file 
would work better (so, a new file starts every month).  With a config file 
entry to disable tracing of the XML messages.

Original comment by kbeck...@cox.net on 15 Sep 2011 at 8:09

GoogleCodeExporter commented 9 years ago 
Fixed in v2.5.0.9.

Original comment by joseph.f...@gmail.com on 3 Aug 2012 at 4:14