search

carygravel / gtk3-imageview

2 stars 3 forks source link

Don't block context menu #8

Closed DarthGandalf closed 4 years ago

carygravel commented 4 years ago

And while you're at it, please fix the PC warning:

t/91_critic.t ...... 1/? 
#   Failed test 'Test::Perl::Critic for "lib/Gtk3/ImageView/Tool/Dragger.pm"'
#   at /usr/share/perl5/Test/Perl/Critic.pm line 121.
# 
#   3 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 17, column 28.  Unnamed numeric literals make code less maintainable.  (Severity: 2)

#   Failed test 'Test::Perl::Critic for "lib/Gtk3/ImageView/Tool/Selector.pm"'
#   at /usr/share/perl5/Test/Perl/Critic.pm line 121.
# 
#   3 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 37, column 28.  Unnamed numeric literals make code less maintainable.  (Severity: 2)
t/91_critic.t ...... Dubious, test returned 1 (wstat 256, 0x100)
DarthGandalf commented 4 years ago

Done

DarthGandalf commented 4 years ago

Could you add me to the collaborators here?

carygravel commented 4 years ago

Could you add me to the collaborators here?

Are you talking about https://developer.github.com/v3/projects/collaborators/#add-project-collaborator ?

DarthGandalf commented 4 years ago

That's API. The same should be available in Settings in an easier way. If you still want me to help you triage issues etc