carykh / jumpcutter

Automatically edits vidx. Explanation here: https://www.youtube.com/watch?v=DQ8orIurGxw
MIT License
3.07k stars 544 forks source link

Bad quality? #104

Open bruhhhhhhhhhh7 opened 5 years ago

bruhhhhhhhhhh7 commented 5 years ago

When I run the program and set the quality to 1, I don't get source quality. Maybe it's throttling on lower spec systems? I'm using flv in OBS for recording. Using a t430.

Edit: I'm going to try multiple file types.

torsrex commented 5 years ago

Not sure if you're referring to video or audio quality, but if you're referring to audio quality try this https://github.com/torsrex/jumpcutter/blob/master/jumpcutter.py . I added a parameter (--stretch_algorithm) to set the audio stretching algorithm. In most cases I got better quality audio by using "wsola" (I set this to be the default) instead of "phasevocoder".

bruhhhhhhhhhh7 commented 5 years ago

No haha, I was talking about video quality. Not sure if it's only on my end though. Appreciate the reply; it might be useful down the line.

soopyc commented 5 years ago

Hey there, if you have fixed your problem, consider closing it. :)

bruhhhhhhhhhh7 commented 5 years ago

Nah, it's still an issue

yunjiewang commented 5 years ago

Try setting qmin to 1 and see if it helps. Otherwise, use lossless format.

smarter-code commented 4 years ago

The issue is with the video encoder used in the tool, replace line 200 in the script with: command = "ffmpeg -framerate "+str(frameRate) +" -i "+TEMP_FOLDER+"/newFrame%06d.jpg -i "+TEMP_FOLDER+"/audioNew.wav -strict -2 " + " -c:v libx264 -pix_fmt yuv420p -crf 0 -c:a aac -b:a 128k "+ OUTPUT_FILE