FFMPEG is used from cmdline, switch to the ffmpeg module instead

carykh / jumpcutter

Automatically edits vidx. Explanation here: https://www.youtube.com/watch?v=DQ8orIurGxw

MIT License

3.07k stars 544 forks source link

FFMPEG is used from cmdline, switch to the ffmpeg module instead #154

Open rizerphe opened 4 years ago

rizerphe commented 4 years ago

FFMPEG should not be used with the 'subprocess' module because it introduces some problems if, for example, video name contains spaces. It can also cause some issues if the vid name is, for example, vid.mp4; sudo rm -r /home.

Switch to ffmpeg-python or something instead.

rizerphe commented 4 years ago

I'm already working on implementing that in a fork...

rizerphe commented 4 years ago

Pull request added

Lamaun commented 4 years ago

Nice quality improvements. As you can see there are quite many pull requests. The reason is that @carykh doesn't seem to have the time to maintain it and did not react to issue #148 yet.