carykh / jumpcutter

Automatically edits vidx. Explanation here: https://www.youtube.com/watch?v=DQ8orIurGxw
MIT License
3.08k stars 541 forks source link

Executable file #3

Open uwuplant opened 5 years ago

uwuplant commented 5 years ago

https://drive.google.com/open?id=1U3KNZlUyaImbub4GhmHu2DY8SEDaWyA0

Hash: 81CB7C1CC4D9B239A82FB65F9F48A8734F3DAECB1ED26A533C2A804D1BADF7D0

uwuplant commented 5 years ago

Can set this up on jenkins to automatically build executable, is it worth it?

balsoft commented 5 years ago

I can help build a standalone linux executable if needed and set up a travis build for that. Having 2 CI's just building executables is great, isn't it?

cthpw103 commented 5 years ago

building a freebsd package

balsoft commented 5 years ago

This is already better than Premiere and Aftereffects because it has support on all the major platforms!

cthpw103 commented 5 years ago

i know right 🤠

cthpw103 commented 5 years ago

also: make an installer with ffmpeg in it.

balsoft commented 5 years ago

also: make an installer with ffmpeg in it.

That's exactly what I'm doing ATM.

cthpw103 commented 5 years ago

should we make a mac os x port?

balsoft commented 5 years ago

should we make a mac os x port?

Consider this in progress.

cthpw103 commented 5 years ago

and also we should make a GUI for this!

cthpw103 commented 5 years ago

yeah with Tkinter, sounds good

balsoft commented 5 years ago

Linux binary

It's just an executable (sort of like AppImage, but without all the fancy squashfs busyness). Download, chmod +x, ./, good to go. ffmpeg and python with all the libraries included. Built with nix.

balsoft commented 5 years ago

Turns out you need a Mac to build stuff for OSX. Too bad.

balsoft commented 5 years ago

Just to double-check that I'm not trying to rm -rf or steal all your precious data, check out #13 to build it yourself (requires POSIX-like system like Linux, OSX or WSL and nix).

balsoft commented 5 years ago

We could make a VM and build it from there, maybe? Possibly? idk, never done anything with OSX

Yeah, VM with hackintosh might work, too much effort tho.

wgarrity-1 commented 5 years ago

My windows build works with Python 3. I had an issue with the above one looking for Python 2. Here is the link: https://github.com/will9183/jumpcutter/releases/download/v1.0-beta/jumpcutter-win.zip

uwuplant commented 5 years ago

Sorry, I use python 2 atm, so my executables won't be compatible with 3.x for now. Will figure out tomorrow.

wgarrity-1 commented 5 years ago

Ya and I think mine doesn't require python to be installed beforehand but ffmpeg. My plan is to make an NSIS installer that does all of this. I have done this in the past.

pniedzwiedzinski commented 5 years ago

Docker image might also be a good idea

balsoft commented 5 years ago

Docker image might also be a good idea

I can build a docker image from nix expression quite easily if needed. Someone please ping me if this would be helpful.

nevercast commented 5 years ago

I like the idea of building this on Travis, This keeps the build process open source and transparent.

cthpw103 commented 5 years ago

this is the only good editing software that works on linux

DeflatedPickle commented 5 years ago

@cthpw103 and @kbartek05, since you mentioned it, I made a GUI for the program and I've created a pull request at #35.

Edit: I didn't realise there was a new issue for this, whoops.

JettJamez commented 5 years ago

How does this work? I open it and it just kinda closes...

balsoft commented 5 years ago

@JettJamez are you talking about Windows version or Linux version?

wgarrity-1 commented 5 years ago

@JettJamez If it is the windows version you have to run it from the command line.

wgarrity-1 commented 5 years ago

I made a very basic installer with @DeflatedPickle GUI: https://github.com/will9183/jumpcutter/releases/download/v1.1-beta/jumpcutter-installer.exe I'm planning on making a better install interface and an option to install ffmpeg

cthpw103 commented 5 years ago

i like this progress

JettJamez commented 5 years ago

@balsoft and @will9183 thx, sorry i didnt see earlier.

wgarrity-1 commented 5 years ago

New installer with bug fixes from @DeflatedPickle and I and new installer UI: https://github.com/will9183/jumpcutter/releases/download/v1.2-beta/jumpcutter-installer.exe

wgarrity-1 commented 5 years ago

And it seems like it throws some issues when I tested this in a virtual machine. This is the error I get when I click run: Exception in Tkinter callback Traceback (most recent call last): File "tkinter\__init__.py", line 1705, in __call__ File "gui.py", line 77, in run File "subprocess.py", line 323, in call File "subprocess.py", line 775, in __init__ File "subprocess.py", line 1178, in _execute_child FileNotFoundError: [WinError 2] The system cannot find the file specified It seems like an issue with my pyinstaller package not picking up tkinter files. Does anyone with better pyinstaller knowledge know how to fix this?

DeflatedPickle commented 5 years ago

@will9183, it's not to do with tkinter. You're getting the error because subprocess can't find the jumpcutter.py file. Try listing the working directory?

wgarrity-1 commented 5 years ago

Here is the directory listing: listing.txt The only problem is that jumpcutter.py is in there.

DeflatedPickle commented 5 years ago

@will9183, but the GUI isn't (unless I missed it). Try adding the jumpcutter.py file as a resource for your EXE?

wgarrity-1 commented 5 years ago

So the GUI is in there as jumpcutter-gui.exe and jumpcutter.py is included (this is the command I used: pyinstaller --add-binary jumpcutter.py;. -n jumpcutter-gui --uac-admin gui.py jumpcutter.py). So I tied a workaround and tried adding my jumpcutter.exe from my excutable from earier. It doesn't give an error but it throws another error: output.txt. This error also happens in the executable without the GUI. So I am guessing that there was an issue with scipy not being included in the package?

Edit: Also I changed subprocess to find the exe instead of the python file.

Lamaun commented 5 years ago

For everyone who is searching for Dockerfiles: To my knowledge there are currently 2 Dockerfile providing forks: https://github.com/rezemble/jumpcutter https://github.com/Lamaun/jumpcutter/