Feature: Added screen size parameters

carykh / recordTrimEdit

Records audio, trims it, and allows you to edit it, all in one fell swoop.

MIT License

70 stars 11 forks source link

Feature: Added screen size parameters #16

Open musahaydar opened 6 months ago

musahaydar commented 6 months ago

Changes in this PR:

Added SCREEN_WIDTH and SCREEN_HEIGHT values to config.json as well as default values when generating a config
Added a warning print statement when no config is found
Used config SCREEN_WIDTH and SCREEN_HEIGHT values to scale size of screen as well as to set position of the waveform and the transcript text on the screen

Alan-Mejia commented 6 months ago

I tried to run this version on windows 11 on a 1920x1080 resolution screen, but still getting audio_array.reshape() issue.

Traceback (most recent call last): File "C:...\recordTrimEdit-feature-screensize\recordTrimEdit.py", line 309, in drawWaveforms(screen) File "C:...\recordTrimEdit-feature-screensize\recordTrimEdit.py", line 167, in drawWaveforms audio_array.reshape((882)) ValueError: cannot reshape array of size 1764 into shape (882,)

I also configured my config.json props.

Am I doing something wrong from my end? 😵‍💫

musahaydar commented 6 months ago

I was able to reproduce this error on the main branch, running Windows 11, Python 3.12.2, in PowerShell. I normally run this in WSL, and this issue does not occur. So it seems this issue is in the main branch, not this version.

ben9583 commented 6 months ago

Ok, I'm gonna try boot camping my Mac to see if I can work on this that way. Seems clear that Windows just does things differently than what the program is expecting.