search

carykh / recordTrimEdit

Records audio, trims it, and allows you to edit it, all in one fell swoop.
MIT License
70 stars 11 forks source link

No license found #2

Closed JacksonChen666 closed 7 months ago

JacksonChen666 commented 7 months ago

This project does not seem to have a license declared in an obvious way, or at all. A license should be added (as this project seems to be intended as open source) so that users can run, modify, study, distribute, and use the code.

https://choosealicense.com/no-permission/

Drogobo commented 7 months ago

I would recommend the GPLv3, or X11 license.

izzy commented 7 months ago

Given that this references pygame as a source, which in itself uses LGPL-2.1-or-later, there's not a lot of room for what license this repo actually could be.

ben9583 commented 7 months ago

Since I'm not the copyright holder I'll defer working on this issue unless Cary gives input

ThatOneCalculator commented 7 months ago

+1 on expediting this. It's often impossible to package code for redistribution on package managers without a license

ben9583 commented 7 months ago

Given that this references pygame as a source, which in itself uses LGPL-2.1-or-later, there's not a lot of room for what license this repo actually could be.

This is not true. You only need to do this if you modify pygame itself, otherwise you just need to include the source code of pygame.

izzy commented 7 months ago

Given that this references pygame as a source, which in itself uses LGPL-2.1-or-later, there's not a lot of room for what license this repo actually could be.

This is not true. You only need to do this if you modify pygame itself, otherwise you just need to include the source code of pygame.

Please have a look at the referenced source that's mentioned in the first line of the code:

# Source: https://github.com/pygame/pygame/blob/main/examples/audiocapture.py

If you diff it it's somewhat obvious cary used this as a basis and while there's not much left, there's still whole chunks from the original that are in the code verbatim.

So this seems to very likely be a (heavily) modified version of parts of the source of pygame and as such would need to use the aforementioned license(or a compatible one).

ben9583 commented 7 months ago

If you diff it it's somewhat obvious cary used this as a basis and while there's not much left, there's still whole chunks from the original that are in the code verbatim.

The examples are in the public domain.

carykh commented 7 months ago

I added an MIT license! It's the most free option, since I want other people to be able to toy around and modify my code freely, as long as they acknowledge that i'm the original owner