caryll / otfcc

Optimized OpenType builder and inspector.
Apache License 2.0
422 stars 63 forks source link

Cannot properly dump transformation matrix in U+1D1D in Noto Sans #56

Closed CyanoHao closed 5 years ago

CyanoHao commented 5 years ago

This is original U+1D1D in Noto Sans: screenshot 34

After running

otfccdump.exe NotoSans-Regular.ttf | otfccbuild.exe -o a.ttf

it looks like this: screenshot 33

otfccdump dumps U+1D1D in Noto Sans to this:

        "uni1D1D": {
            "advanceWidth": 618,
            "references": [
                {"glyph":"n","x":38,"y":584,"a":0,"b":-1,"c":1,"d":-1,"roundToGrid":true}
            ],
            "instructions": ["PUSHB_2",0,1,"PUSHW_1",584,"PUSHB_1",51,"CALL"]
        },

It seems that "d" should be 0.

NotoSans-Regular.zip otfcc version: 0.10.3 (prebuilt Windows x64, downloaded from https://github.com/caryll/otfcc/releases/tag/v0.10.3-alpha)

be5invis commented 5 years ago

I made a fix in master. You can try to rebuild it on your own. OTFCC is now in a maintenance mode (I have a TypeScript project internally in MSFT does the same thing).