Failing build on ubuntu

ygrange commented 5 years ago

When trying to build casarest using the standard LOFAR Docker building, I got a huge bunch of errors

make
[  0%] Building CXX object components/CMakeFiles/casa_components.dir/SpectralComponents/CompiledSpectralElement.cc.o
In file included from /opt/casarest/src/components/SpectralComponents/CompiledSpectralElement.h:32:0,
                 from /opt/casarest/src/components/SpectralComponents/CompiledSpectralElement.cc:27:
/opt/casarest/src/components/SpectralComponents/SpectralElement.h:108:10: error: 'Double' does not name a type
  virtual Double operator()(const Double x) const;
          ^
/opt/casarest/src/components/SpectralComponents/SpectralElement.h:110:2: error: 'Bool' does not name a type
  Bool operator==(const SpectralElement& other) const;
  ^
/opt/casarest/src/components/SpectralComponents/SpectralElement.h:116:10: error: 'Double' does not name a type
  virtual Double operator[](const uInt n) const;
          ^
/opt/casarest/src/components/SpectralComponents/SpectralElement.h:119:15: error: 'String' does not name a type
  static const String* allTypes(Int &nall,
               ^

Those are the cmake flags used:

ake -DCMAKE_INSTALL_PREFIX=${INSTALLDIR}/casarest -DCASACORE_ROOT_DIR=${INSTALLDIR}/casacore -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_FLAGS="-std=c++11 -O2 -march=native -DNDEBUG" ../src/

Can anybody explain to me what I am doing wrong here...? I use casacore 3.0.0 and for the rest all dependencies come from the ubuntu 16.04 repo.

gijzelaerr commented 5 years ago

my guess is that casarest is nog c++11 compatible.

gijzelaerr commented 5 years ago

maybe try this branch:

https://github.com/casacore/casarest/pull/23

if that works for you i'll merge it and make a new release

ygrange commented 5 years ago

That branch works like a charm! Thanks! Would be appreciated to have a release that incooperates it :)

casacore / casarest

Failing build on ubuntu #24