search

casacore / python-casacore

Python bindings for casacore, a library used in radio astronomy
http://casacore.github.io/python-casacore
GNU Lesser General Public License v3.0
35 stars 22 forks source link

Improve find_boost and find_casacore in setup #194

Closed tammojan closed 4 years ago

tammojan commented 4 years ago

The library dirs and include dirs found in setup.py are now passed to the compiler. Find_boost has been improved to always prefer library names with versions over those without. So 'boost_python36' is now preferred over 'boost_python-mt' (it was the other way around).

Including the header dir will fix issues with 'missing symbols' since it could happen that a header from a previous boost installation was available in a system path, which was slightly incompatible with the boost library used at runtime.

pep8speaks commented 4 years ago

Hello @tammojan! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 75:80: E501 line too long (85 > 79 characters) Line 76:80: E501 line too long (80 > 79 characters) Line 77:80: E501 line too long (80 > 79 characters) Line 109:80: E501 line too long (86 > 79 characters) Line 110:80: E501 line too long (86 > 79 characters) Line 146:80: E501 line too long (85 > 79 characters) Line 155:80: E501 line too long (90 > 79 characters) Line 161:80: E501 line too long (90 > 79 characters) Line 191:80: E501 line too long (116 > 79 characters) Line 214:80: E501 line too long (84 > 79 characters) Line 215:80: E501 line too long (92 > 79 characters)