search

casacore / python-casacore

Python bindings for casacore, a library used in radio astronomy
http://casacore.github.io/python-casacore
GNU Lesser General Public License v3.0
35 stars 22 forks source link

Give error when casacore is too old #195

Closed tammojan closed 4 years ago

tammojan commented 4 years ago

The travis tests using KERN all fail on a unicode error. Probably this was fixed in casacore 3.1.1, which has unicode improvements. I'll bump to KERN5 to see if it helps, but KERN5 has casacore ~2.5.0~ 3.0.0, so probably not.

pep8speaks commented 4 years ago

Hello @tammojan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 124:9: E722 do not use bare 'except' Line 243:1: E303 too many blank lines (3) Line 246:43: E271 multiple spaces after keyword Line 246:80: E501 line too long (113 > 79 characters) Line 247:80: E501 line too long (105 > 79 characters)

Comment last updated at 2020-04-16 15:31:22 UTC
tammojan commented 4 years ago

I added an error to setup.py to raise an Exception when casacore is detected and the version can be extracted, but it is too old. The result is here:

RuntimeError: Your casacore version is too old. Minimum is 3.1.1, you have 2.5.0
tammojan commented 4 years ago

Rebased on master. I made an extension to build_ext that will crash if casacore is too old. This should make sure that setup.py can still be run to do e.g. setup.py clean. This is tested in one of the travis jobs.

gijzelaerr commented 4 years ago

hey! nog niet gereviewd :)

tammojan commented 4 years ago

Oops...

gijzelaerr commented 4 years ago

maar ziet er goed uit, mooi zerk. volgens mij zou dit wel moeten werken. laten we zien wat er gebeurt tijdens packagen.